| CODENOTIFIER | HelpYou are not signed inSign in |
Project: Google Web Toolkit
Revision: 3598
Author: scottb@google.com
Date: 29 Aug 2008 21:47:21
Changes:Trap unchecked exceptions thrown by generators.
Patch by: cromwellian
Review by: me
| ... | ...@@ -45,19 +45,26 @@ | |
| 45 | 45 | } |
| 46 | 46 | |
| 47 | 47 | long before = System.currentTimeMillis(); |
| 48 | String className = generator.generate(logger, context, typeName); | |
| 49 | long after = System.currentTimeMillis(); | |
| 50 | if (className == null) { | |
| 51 | msg = "Generator returned null, so the requested type will be used as is"; | |
| 52 | } else { | |
| 53 | msg = "Generator returned class '" + className + "'"; | |
| 54 | } | |
| 55 | logger.log(TreeLogger.DEBUG, msg, null); | |
| 48 | try { | |
| 49 | String className = generator.generate(logger, context, typeName); | |
| 50 | long after = System.currentTimeMillis(); | |
| 51 | if (className == null) { | |
| 52 | msg = "Generator returned null, so the requested type will be used as is"; | |
| 53 | } else { | |
| 54 | msg = "Generator returned class '" + className + "'"; | |
| 55 | } | |
| 56 | logger.log(TreeLogger.DEBUG, msg, null); | |
| 56 | 57 | |
| 57 | msg = "Finished in " + (after - before) + " ms"; | |
| 58 | logger.log(TreeLogger.DEBUG, msg, null); | |
| 58 | msg = "Finished in " + (after - before) + " ms"; | |
| 59 | logger.log(TreeLogger.DEBUG, msg, null); | |
| 59 | 60 | |
| 60 | return className; | |
| 61 | return className; | |
| 62 | } catch (RuntimeException e) { | |
| 63 | logger.log(TreeLogger.ERROR, "Generator '" | |
| 64 | + generator.getClass().getName() | |
| 65 | + "' threw threw an exception while rebinding '" + typeName + "'", e); | |
| 66 | throw new UnableToCompleteException(); | |
| 67 | } | |
| 61 | 68 | } |
| 62 | 69 | |
| 63 | 70 | public String toString() { |